Skip to content

Conversation

@ianlancetaylor
Copy link
Contributor

This is based closely on the TypeScript code.

The s05 tests don't work yet. They get an error

LookupGeneratorAction: no generator action named "google-vertexai"/"gemini-1.0-pro-vision"

Using the gemini-1.0-pro action (without "-vision") doesn't work,
saying that it doesn't support the input type.

This is based closely on the TypeScript code.

The s05 tests don't work yet. They get an error

LookupGeneratorAction: no generator action named "google-vertexai"/"gemini-1.0-pro-vision"

Using the gemini-1.0-pro action (without "-vision") doesn't work,
saying that it doesn't support the input type.
@ianlancetaylor ianlancetaylor requested review from jba and randall77 May 31, 2024 23:37
@ianlancetaylor
Copy link
Contributor Author

I don't understand how to update this for the changes on the main branch, so closing this pull request in favor of #300.

@ianlancetaylor ianlancetaylor deleted the iant branch June 3, 2024 04:19
@jba
Copy link
Contributor

jba commented Jun 3, 2024

Pull and rebase as you would in gerrit, then git push -f.
I think that might mess with comments on defunct commits, but there weren't any in this case.

@ianlancetaylor
Copy link
Contributor Author

In Gerrit the pull and rebase is handled for me via git codereview sync. Would that work on a non-Gerrit repo?

@jba
Copy link
Contributor

jba commented Jun 4, 2024

I don't know. I've never used that command (pure fear). I do it manually.
One concern is that in gerrit, each CL is one commit, so git codereview sync probably always rebases just one commit.
If your PR consists of multiple commits, you have to rebase them all onto main.
For example, if there are three commits, the command, when you are on the PR branch, is

git rebase HEAD~3 --onto main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants